RE: [PATCH] cygcheck: follow symbolic links

["Dave Korn" <dave dot korn at artimi dot com>]

On 16 February 2006 17:27, Igor Peshansky wrote:

> On Thu, 16 Feb 2006, Corinna Vinschen wrote:

>> - Couldn't you just reuse the readlink implementation in ../cygwin/path.cc
>>   as is, to avoid having to different implementations?
> 
> Umm, most of that code is very general purpose, and has too much extra
> stuff in it.

  I think you may have misoptimised for speed rather than maintainability.
Cygcheck isn't something that people expect to run a million times per second
in an inner loop.

>  I basically used part of it (symlink_info::check_shortcut)
> for my implementation.  I wanted something lightweight and easy to
> understand 

  Perhaps you could have just exported it (or a convenient interface to it)
instead?

>(also, the code in path.cc doesn't check for PE headers, so I
> had to write that part anyway).

  None of which affects /that/ bit.


    cheers,
      DaveK
-- 
Can't think of a witty .sigline today....