This is the mail archive of the
cygwin-patches@cygwin.com
mailing list for the Cygwin project.
Re: [PATCH]: 2. Thread safe stdio update
On Fri, Jan 23, 2004 at 12:03:09PM +0100, Thomas Pfaff wrote:
>Corinna Vinschen wrote:
>>On Jan 22 21:48, Thomas Pfaff wrote:
>>
>>>This is an update of my previous patch. It adds support for newlibs
>>>__LOCK_INIT macro.
>>>
>>>Thomas
>>>
>>>2004-01-22 Thomas Pfaff <tpfaff@gmx.net>
>>>
>>> * include/sys/_types.h: New file.
>>
>>
>>I'm not quite sure if that's the way to go. I'm wondering if we
>>shouldn't keep newlib's _types.h and change it like this:
>>
>> #ifdef __CYGWIN__
>> #include <cygwin/_types.h>
>> #endif
>>
>> #ifndef __CYGWIN__
>> typedef int _flock_t;
>> #endif
>>
>>Then we can create a cygwin/_types.h with the correct _flock_t definition.
>>IMHO that's cleaner than just overloading newlib's _types.h.
>
>You may be right.
>
>I just followed the way it was done in newlibs linux support where a
>modified _types.h is in newlib/libc/sys/linux/sys (and it was the
>easiest way for me to test it).
Btw, I agree with Corinna's assessment here. That's one reason why I
didn't just drop this into the release. I'd like to minimize the amount
of header duplication we have between cygwin and newlib. And, wholesale
duplication with just one small change is always a bad idea.
cgf