This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: fhandler_base::ioctl (FIONBIO)


On Fri, Oct 24, 2003 at 09:50:38AM -0500, Brian Ford wrote:
> On Fri, 24 Oct 2003, Corinna Vinschen wrote:
> 
> > On Thu, Oct 23, 2003 at 06:06:09PM -0500, Brian Ford wrote:
> > > Any reason not to support this?  It seams to me that this patch just
> > > parallels what is already in fhandler_base::fcntl (F_SETFL) for
> > > O_NONBLOCK.
> >
> > Yes, I think you're right.  However, I'd like to ask you to rearrange
> > your patch a bit.  Most (all?) other ioctl methods are using a switch
> > statement rather than a if/else clause.  To allow later easier extension,
> > I think using a switch here would be better as well, even though there's
> > only one case so far.
> >
> Ok.  Revised as suggested and attached.  Same ChangeLog entry.
> [...]
> > > 	* fhandler.cc (fhandler_base::ioctl): Handle FIONBIO.

Thanks.  I've checked it in.

Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Developer                                mailto:cygwin@cygwin.com
Red Hat, Inc.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]