This is the mail archive of the
cygwin-patches@cygwin.com
mailing list for the Cygwin project.
Re: Part 2 of Fixing a security hole in pinfo.
On Sat, Sep 13, 2003 at 10:30:55PM -0400, Christopher Faylor wrote:
> On Sat, Sep 13, 2003 at 10:07:42PM -0400, Pierre A. Humblet wrote:
> >This is the second and final part of the pinfo security patch.
>
> Looks like a Corinna yea or nay on this one.
The changes look good. Please apply, Pierre.
FYI:
What bugged me when reading the patch was my decision at one point to
use the phrase "orig_sid". The "orig_sid" is basically what is called
a "saved id" in POSIX systems and I think it would help reading the
code if we also rename orig_sid/orig_uid/orig_gid to saved_sid/saved_uid/
saved_gid and using the phrase "saved" instead of "orig" or "original"
throughout.
So, after you have applied the patch, I'll do all the renaming within
this week.
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Developer mailto:cygwin@cygwin.com
Red Hat, Inc.