This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: fhandler_tty patch


----- Original Message -----
From: "Christopher Faylor" <cgf@redhat.com>
To: <cygwin-patches@cygwin.com>
Sent: Sunday, November 03, 2002 7:37 PM
Subject: Re: fhandler_tty patch

> > * fhandler_tty.cc (fhandler_tty_slave::ioctl): Do nothing if the new
> > window size is equal to the old one.  Send SIGWINCH if slave connected
> > to a pseudo tty.
> > (fhandler_pty_master::ioctl): Do nothing if the new window size is
> > equal to the old one.
>
> Is this according to some standard?  It seems like we're sending too many
> SIGWINCHes with your patch.
>

Without the patch we're not sending SIGWINCH at all. ioctl(tty, TIOSWINSZ,
...) supposed to send SIGWINCH if the window size changed. The ioctl() call
should work in the same way for both master and slave ends of pseudo tty,
without the patch the ioctl works for master end only, but many unix
programs (screen for example) change the window size of the slave end.

Sergey Okhapkin
Somerset, NJ



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]