This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

init_cheap and _csbrk


I stumbled over this last night but I thought it better to wait
until I'd had both sleep and pizza before posting it off :-)

The _csbrk function, from "cygheap.cc", is rounding up the first
allocation to a multiple of a page size, which seems unnecessary
since VirtualAlloc does that anyway (i.e., if you reserve/commit a
single byte on a page, it reserves/commits the whole page).  More
importantly, it can't be right to add the allocation request size
to the return value for the first allocation (except that the
first "allocation" is probably always 0, so actually it's
alright).

And while I was there I moved one initialization about for the
usual "aesthetic" reasons :-)

// Conrad

Attachment: ChangeLog.txt
Description: Text document

Attachment: cygheap.patch.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]