This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fw: dup tty error.


> >2002-06-30  Christopher January <chris@atomice.net>
> >
> > * tty.cc (tty_list::allocate_tty): retry FindWindow if it fails.
>
>        __small_sprintf (buf, "cygwin.find.console.%d", myself->pid);
>        SetConsoleTitle (buf);
> -      Sleep (40);
> -      console = FindWindow (NULL, buf);
> +      for (int times = 0; times < 25 && console == NULL; times++)
> +           {
> +                 Sleep (40);
> +          console = FindWindow (NULL, buf);
> +           }
>        SetConsoleTitle (oldtitle);
>        Sleep (40);
>        ReleaseMutex (title_mutex);
>
> Is the SetConsoleTitle really succeeding when the window doesn't exist
> yet?  That seems really broken to me but I guess that not too surprising.
>
> I'm just wondering if we should be looping on the SetConsoleTitle rather
> than the FindWindow.
I did some testing and it seemed like looping on SetConsoleTitle was
unnecessary. I believe the window is open at this point, but the title is
set asynchronously, hence the loop to wait for the title to change.

Chris



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]