This is the mail archive of the
cygwin-patches@cygwin.com
mailing list for the Cygwin project.
Re: [PATCH] Get recursive grep to work on Win9x
- From: Ton van Overbeek <tvoverbe at cistron dot nl>
- To: cygwin-patches at cygwin dot com
- Date: Mon, 13 May 2002 10:25:29 +0200
- Subject: Re: [PATCH] Get recursive grep to work on Win9x
Chris Faylor wrote:
> I've checked in a slightly different version which should have the same
> effect.
>
> I appreciate the time you spent tracking this down and researching the
> correct method for fixing this. I used roughly the same technique as
> you but moved it to only affect the opening of disk files. Hopefully,
> it will fix your problem.
>
Attacking the problem in fhandler_disk_file::open before fhandler_base::open
is called is a better place and more efficient.
Checked grep -R execution with the snapshot (cygwin-20020513.dll) and it
works on W98SE.
> Btw, for future reference, your patch was reversed. It should have been
> diff -u foo.orig foo, i.e. the original file goes first.
I hope I remember it next time around ...
Maybe you could mention this on http://cygwin.com/contrib.html.
Now it mentions only using 'cvs diff -up' to generate the patch.
Anyway I hope this has brought cygwin.dll 1.3.11 a bit closer.
Ton van Overbeek