This is the mail archive of the
cygwin-patches@cygwin.com
mailing list for the Cygwin project.
RE: For the curious: Setup.exe char-> String patch
- From: "Robert Collins" <robert dot collins at itdomain dot com dot au>
- To: "Gary R Van Sickle" <tiberius at braemarinc dot com>,<cygwin-patches at cygwin dot com>
- Date: Sat, 2 Feb 2002 13:46:58 +1100
- Subject: RE: For the curious: Setup.exe char-> String patch
> -----Original Message-----
> From: Gary R Van Sickle [mailto:tiberius@braemarinc.com]
>
> I think it would behoove us greatly to duplicate the semantics of
> std::string here, and return a zero-based offset on success,
> and an "npos"
> on failure.
Whats a 'npos' defined as?
> > geturl.cc:
> >
> > static void
> > -init_dialog (char const *url, int length, HWND owner)
> > +init_dialog (String const url, int length, HWND owner)
> ^^^^^^^^^^^^^^^^
>
> This would be better written "const String &url".
Weeel, yes it would, yet another typo. Fortunately String copies are
very lightweight :}.
(One addition, one subtraction, and if test and 4 bytes of storage)
Rob