This is the mail archive of the
cygwin-patches@cygwin.com
mailing list for the Cygwin project.
Re: [PATCH] dlfcn.cc
On Thu, Nov 01, 2001 at 09:34:12PM -0500, Christopher Faylor wrote:
>On Fri, Nov 02, 2001 at 11:21:35AM +0900, Jong B. Lee wrote:
>>Dear list,
>>
>>With this patch, moule self test seems to work.
>
>I'm sorry but there are several things wrong with this patch.
>
>1) The formatting is really screwed up. That's fixable of course.
>
>2) You're apparently using global or static variables to save state.
> You can't do that in a multi-threaded application. Actually, in
> this case, it appears that this isn't even a multi-threaded
> consideration. It doesn't seem like this would even be safe for
> multiple calls to dlopen.
>
>3) There is already a mechanism for doing some of what you are trying
> to do with toolhelp or psapi in another part of cygwin (pinfo.cc).
> It would be best to consolidate with the other code.
>
>4) Your ChangeLog entry is wrong. Please read http://cygwin.com/contrib.html
> for pointers to how to write a ChangeLog entry. The current cygwin
> ChangeLog should also be helpful.
>
>Finally, for a patch of this side, you'll need to send in an assignment form
size
cgf