This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

RE: [PATCH] Move per_thread::set() def from fork.cc to perthread.h


[snip]

> >The idea isn't to get it into the header, but rather to get it out of
> >fork.cc, where it doesn't belong.  Currently, there is no 
> perthread.cc; the
> >entire per_thread class is implemented in the header.  I agree, 
> there's most
> >likely no reason this shouldn't be in a .cc file.
> 
> I agree with Robert that putting this is in the header doesn't seem like
> the right thing to do.  It's in fork.cc primarily because I wanted it
> to be in a .cc file for debugging purposes.
>

Ah, good point.  Do you have any objections then to a perthread.cc?
 
> I have checked in your debug change fix, though.  Thanks.
>

Thank you!
 
> cgf
> 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]