This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: patch for displaying package name before package descriptor


On Thu, Oct 11, 2001 at 10:46:16AM +1000, Robert Collins wrote:
>
>----- Original Message -----
>From: "Ralf Habacker" <Ralf.Habacker@freenet.de>
>To: "Cygwin-Patches" <cygwin-patches@sourceware.cygnus.com>
>Sent: Thursday, October 11, 2001 4:52 AM
>Subject: patch for displaying package name before package descriptor
>
>
>> Hi,
>> I have seen a current setup.exe in cvs and recognized,
>> that prepending the package name to the printed
>> package descriptor help to identify the displayed package.
>> The following patch added this functionality.
>>
>> BTW: In some packages the package name is already in the
>> package descriptor. If this would be cleared (removed)
>> the lines
>> +       // package name is already in descriptor
>> +       if (strncmp(pkg->sdesc,pkg->name,strlen(pkg->name)) == 0)
>>            s = pkg->sdesc;
>> +
>> +       // otherwise prepend the package name
>> +       else {
>> could be removed from the patch.
>
>Right, well thats easy enough to fix :}. So those lines aren't needed.
>This looks good to me Chris.
>
>I've got a little mental anguish over whether we should do this during
>parsing, and save all the duplication, or even just have a separate
>column with the package name in it. However, this code is hre, and
>working so AFAIAC it should go in.
>
>Thanks Ralf!

Do you want to check this in, then, Rob?

cgf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]