This is the mail archive of the
cygwin-patches@cygwin.com
mailing list for the Cygwin project.
Re: yet another "pedantic" patch
- To: cygwin-patches at cygwin dot com
- Subject: Re: yet another "pedantic" patch
- From: Christopher Faylor <cgf at redhat dot com>
- Date: Thu, 13 Sep 2001 13:34:24 -0400
- References: <11495323718.20010913194455@logos-m.ru>
- Reply-To: cygwin-patches at cygwin dot com
On Thu, Sep 13, 2001 at 07:44:55PM +0400, egor duda wrote:
>Hi!
>
> I've added input parameter checking to some functions so that new
>tests in the testsuite will run smoothly.
>
>Does anybody know why we link with libstdc++? I've removed it and
>everything links and runs ok.
Can I suggest that you modify the check_null_empty_* to pass
in an errno that should be used in the case of an empty string?
You are special casing checks to force an EINVAL.
Hmm. I wonder if EINVAL is always appropriate for an empty string.
It could just be wrong in check_null_empty_str.
Thanks for doing this due diligence.
cgf