This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: yet another "pedantic" patch


On Thu, Sep 13, 2001 at 07:44:55PM +0400, egor duda wrote:
>Hi!
>
>  I've added input parameter checking to some functions so that new
>tests in the testsuite will run smoothly.
>
>Does anybody know why we link with libstdc++? I've removed it and
>everything links and runs ok.

Can I suggest that you modify the check_null_empty_* to pass
in an errno that should be used in the case of an empty string?

You are special casing checks to force an EINVAL.

Hmm.  I wonder if EINVAL is always appropriate for an empty string.
It could just be wrong in check_null_empty_str.

Thanks for doing this due diligence.

cgf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]