Re: Seeking developer to assist with adding OpenAFS Reparse Tag Support to Cygwin

[Jeffrey Altman <jaltman at openafs dot org>]

On 3/10/2013 4:35 PM, Corinna Vinschen wrote:
> On Mar 10 15:19, Christopher Faylor wrote:
>> On Sun, Mar 10, 2013 at 09:09:42AM -0400, Jeffrey Altman wrote:
>>> On 3/10/2013 1:50 AM, Christopher Faylor wrote:
>>>>
>>>>> Do not hesitate to ask if you have any questions.
>>>>
>>>> Could you reformat that without the MS-DOS line endings.
>>>
>>> Here is the same file after running 'dos2unix' on it.
>>
>> Sorry to nickel and dime you, but convention is to use unified diff
>> format when submitting patches.  I should have mentioned that before.
>>
>> >From what I can see, your changes don't follow the indentation
>> convention of the code around it, i.e., the changes in path.h
>> seem to use four spaces for indentation.
> 
> A ChangeLog entry would be helpful, too.

Please consider converting to 'git' and deploying 'gerrit' for code
review.  You will find it makes not only your only life happier but make
it make easier on flyby contributors.


> This is all nicely described on http://cygwin.com/contrib.html
> under the "When you have finalized your changes" section.


I will read.