This is the mail archive of the
cygwin-developers@cygwin.com
mailing list for the Cygwin project.
Re: stat matters
Christopher Faylor wrote:
>
> On Fri, May 30, 2003 at 09:46:20AM -0400, Pierre A. Humblet wrote:
> >Christopher Faylor wrote:
> >>
> >> On Thu, May 29, 2003 at 11:05:00PM -0400, Pierre A. Humblet wrote:
> >
> >> >
> >> >I can't test the patch now, but it looks like all files on FAT
> >> >will be marked NOTEXEC if ntsec is on.
> >>
> >> Correct. They will be marked as "don't open the file to check for
> >> executable". If there was an actual "don't care" state, I would have
> >> used that.
> >
> >But on FAT we want to open the file and check, don't we?
>
> Duh, right. I missed the FAT part of your question. I thought you were
> inferring that all files opened using ntsec would be marked as
> non-executable. There are other problems with that section of code,
> too. I'll rectify them.
I think the cleanest way is to only mark EXEC or NOTEXEC in path.cc
if we really know them to be true, and to carry the "will use ntsec" in
the bit currently used by pc->has_acls(). This has no negative side
effect if the file system flag is used directly for the inode stuff.
Then fhandler_disk_file::fstat can combine "dont_know_if_executable"
and "renamed pc.has_acl()" to decide query_open.
Pierre