Re: [RFA] A kinder, gentler check for /etc/{passwd,group} changes

[egor duda <deo at logos-m dot ru>]

Hi!

Sunday, 09 September, 2001 Corinna Vinschen vinschen@redhat.com wrote:

CV> On Sat, Sep 08, 2001 at 10:51:33PM -0400, Christopher Faylor wrote:
>> Here's what I did, based on the FindFirstFileChangeNotification ideas.
>> 
>> It seems to get performance back down to around 1.3.2 levels when
>> combined with a couple of other minor changes.
>> 
>> Now that I see the patch, I realize that the etc_changed function
>> probably belongs in miscfuncs.cc rather than in dcrt0.cc.

CV> IMO it belongs into the class init_cygheap.  I did it that way in
CV> my version of that patch.

>> The only thing I don't know is if the etc_changed function actually
>> does anything useful.  I don't have a useful test case for that but
>> I thought that Corinna might.

CV> It works.  A simple test is ssh.  Start sshd, login using your
CV> account.  Edit /etc/passwd to use tcsh as login shell instead of
CV> bash.  Try another login.

CV> Testing the /etc/group stuff isn't that easy.  The current Cygwin
CV> version doesn't support supplementary groups to add when the user
CV> context changes due to a NTCreateToken() call.  I plan to add it
CV> to 1.3.4 though.

>> I wonder if we could generalize the similar code in passwd.cc and grp.cc
>> into some kind of class for 1.3.4...

CV> See my below patch. The whole class stuff is now in a common
CV> header file `pwdgrp.h'.  There could be more common stuff later,
CV> perhaps.

Should we apply this patch to 1.3.4, while removing /etc/ reread logic
in 1.3.3? Btw, i think that /etc/passwd and /etc/group handling is yet
another good candidate to move to "cygwin-server".

Egor.            mailto:deo@logos-m.ru ICQ 5165414 FidoNet 2:5020/496.19