winsup inode bug + patch

[Andrew Dalgleish <andrewd at axonet dot com dot au>]

There is a bug in the current handling of a file's inode.
I first noticed this when a "mv" failed on a remote drive.

This is most easily verified by doing an "ls -i".
The listed inodes are not unique, and are not always the same for a
given file even when you execute "ls -i foo && ls -i foo".

Using nFileIndexHigh and nFileIndexLow for an inode number is taking a
leap of faith.

Here is the relevant section from the VC6 help (my line wrapping):

  nFileIndexLow
  Specifies the low-order word of a unique identifier associated with
the file.
  This identifier and the volume serial number uniquely identify a file.
  This number may change when the system is restarted or when the file
is opened.
  After a process opens a file, the identifier is constant until the
file is closed.
  An application can use this identifier and the volume serial number to
determine whether two handles refer to the same file. 

Note the phrase "the identifier is constant until the file is closed".
The current code in stat() opens and closes the file.

From what I have observed, the file index *does* change, and is *not*
unique on network drives.
The file index seems ok for local drives with ACLs so it is probably
still worth using it where possible,
reverting to the hashed file name (*without* XORing nFileIndexLow) if it
is not.

The patch below adds a HASINODE flag to path_conv and fhandler_base.
This flag is set in path_conv::path_conv() by calling GetDriveType()
after checking whether the volume supports ACLs.

I have no idea how this affects other classes derived from
fhandler_base, but I have successfully rebuilt 
cygwin-src-19991201.tar.gz + winsup-src-19991204.tar.gz + this patch for
several generations.
I'm having troubles with sub-shells with winsup-src-19991205.tar.gz, so
the patch is relative to 19991204.

From a PC running NT4sp5 workstation, I have tested this works for the
following remote drives:
NT4sp5 server sharing an NTFS drive
NT4sp5 workstation sharing an NTFS drive.
NT4sp5 workstation sharing a FAT32 drive (using the Winternals driver).
Win95 sharing a FAT16 drive.
Win95 sharing a FAT32 drive.
Debian 2.0 + Samba 2.0.4b sharing an ext2 drive.


Regards,
Andrew Dalgleish

 

begin 600 winsup-inode.diff.gz
M'XL("-7H33@``W=I;G-U<"UI;F]D92YD:69F`(U7;7.B2!#^G/R*KKVZ6UTU
M\34O6+L7-^*%BL*6D'VY#T<AC#(5!(\7-;>[__UZ!A`0HYLR*C/]=/=T/]T]
M6G0^AX8?;6!#W2!:-3R?+B[GMN%:#O$O3#-9SR^=-QJ-U\3/OA`+9&\-[2ZT
M>D+O2FC>0.OV]O:\5JL=T,7EA\0$)M85VC?XBN7O[J!QV^K66TVH)9]W=^<`
M,(OFC0]!J+L.=9_Q^3TXGFDX%ZX<+6?$5^9C7`_Z>5&+K`%RHM;FL^=$2Z(2
MGQI.C"L``OH?R0/<$76(BHMC;],_;P#0.51L(]`7GF?IU/4L`I5J];R6[62+
MW'2J&9?W]4JN1;8/=&'#C](RMX<`X@2$V3VM"!'P#RP(!LA8$O3$1B?ZS+,R
MMB25DYDYSSP*[T'5/XX?5>EO<6_?,Y\#IJ52B%HMDV^TJG#Y"CRB5I(2YL0<
MO=>]C4O\.'B&Z03H4)UO(FLZ;>XG"V>?,Z/5NFG6KZ#&/Z\39@#\/`?V)4!4
MIL8GAJ.OC-"^R*F.0Y(*)LDJ2NXRV(^U4C<$GP3H<FC3H/$AI;$^,P(B"-Z*
MN%"9.\8BJ,,2H1QG'2\PNU03]NOE99]I$8FKY1J:/:%Y+?2.5)>]7UQ70J^9
M%==5CP40W]/PC1[TL7(_&/.L-+?-;I/_U<\NWP&C%]``(I=NP?*6!G4A0`*0
M$-Y=)N"1-%(@!=\<`'.!G?C#0!W<CU4NGIB*Q34?3XEE-`_`PW<&QG0`%T9T
M+45+LC(4&?KF%]!KPT'&\90&W`?F!8H/R9J:!'C:XG46FW:[C6&IM=N=^BV/
M3IK_'(/@.[(AC'P7W9%45=1&4$G.5.TS)@*L/;19)"-3@KXP].CA7I&',1"7
MZI!'-S)[A1YSRFJ-]Z`$>0+$`QBC]GQ-@"><S?"[^+B>/O<)X=7Z6I!D9325
M!Q.Q%*4]\#'K!1V':XS7<3;`DL=2=27K^Z5U(S3;I=)*98MUU>H4ZJIS?<T*
MBWUTVKO.5&3!:#!6Q6K6V0^(K#TG)N4?,%+U3^)4E51-E#4]3G6<:$Y@DV*N
M-C8);6R?^`;,34!_5YX?!CG.YZ83LX&=#;['>K@F+86FU58'TR;F,]=I^71-
M('Q9D8M$%<"3)&OQALXVL)+_(N&0/6OX6/$]+TP=Q=-M:&CBE,GDN76V96+_
MA.%4^BSJ3_*CK'R1A=*&K.A31='TH30M;T[%B:*)R7IVFB#O=H!M"^D9IGS,
M-X3X2&<S[/_/_9+VD?15'!XV^GGP<2R6M^Z'4V5R`#&8#"7U\1?\?-W'0H56
MM.D3HU'1=8O,C<@)BV8F*J8539@X'19(7Y93/W+07`,D-.F^#>'9Q;N#C?^A
M!_$0X9,N2WBL?18M])6/U8E<>L,(HYN>NQ:$W5=4&;EDNR)FB):RH\'OUIMZ
MCC#IM81?37('X/T(6P/O*[_A<:B+$2)K\F\EJ$(E"'T6U*7!^<2:11T7JWC3
M.M(([$(-EX=LO'PV\BD,H@6T.M"Z$KI=H7-UN`OL#]=66VCW<DV`WTXZV=WD
MTT![T-5OD[$D/V*AM.J[Q8^2/)A^P[6)\H3E'3]FV^)7\7ZWR1[J+#I\*VW!
M?(2VTR&865/N'T4--_,#=K>;'[_I`,60Q]>K;H>-OVYWYW[D!G3AXHEYDGEC
MZK\R%1/N9H+8P?(6^_GAMC?;3F.1S)?X`R,$9`$U0^<%3,_WD6F'Y]XQA3QV
M_9_I(6@PHZ[AOQS'Q>G)HX*7)?\E<A269+Z`BZ]/QV$\A8AB2>EU&*=Z65)V
M@S/O0D[)C_<'C.]`9(ODY4-VRPA9@F[ASQP#!6CVC]UI3NA(V1:K.7+=.*TG
>IGSB#_,(6YH/[UCS<O4@FL_IEE'S?RA]SK/:#@``
`
end