This is the mail archive of the cygwin-apps mailing list for the Cygwin project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On 2017-07-05 12:01, Corinna Vinschen wrote: > On Jul 5 13:44, Ken Brown wrote: >> On 7/5/2017 1:27 PM, Corinna Vinschen wrote: >>> On Jul 5 11:20, Brian Inglis wrote: >>>> On 2017-07-05 08:27, Corinna Vinschen wrote: >>>>> On Jul 5 13:32, Nellis, Kenneth wrote: >>>>>> So, these are handy links to have, I guess, but is it appropriate for >>>>>> cygwin-doc.sh to presume that the directory exists? Maybe it should create it >>>>>> rather than simply bail out and complain if it doesn't exist. >>>>> >>>>> In theory, the script should only create the files if the directory >>>>> exists. Brian? >>>> >>>> Okay - assumed the directory would always be created by setup - >>>> presumably not true - but do not check that assumption in pi, although >>>> thought about it - >>> >>> User's can decline creating shortcuts in setup. >>> >>>> should I check and skip creating shortcuts, rather than create dir and >>>> shorcuts? Should I also check and skip rm in prerm? And provide >>>> patches? >>> >>> Skipping goes hand in hand with the fact that the user declined the >>> Start Menu shortcut creation. >> >> The script already does check and skip. The only issue is that it skips by >> calling 'exit 2' instead of 'exit 0', which is what led to the original >> post. > > Note to myself: read source before talking about it. Patch(es) attached - shuffled the order of a few things to fail quietly in postinstall - changed preremove to look and take a similar approach to postinstall for consistency - format-patch should apply cleanly this time. -- Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada
Attachment:
0001-fix-cygwin-doc-postinstall-preremove-no-SMPrograms-C.patch
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |