Re: [PATCH setup 4/4] Remove msg() from LogFile::endEntry()

[Corinna Vinschen <corinna-cygwin at cygwin dot com>]

On Mar  2 13:55, Jon TURNEY wrote:
> Every single line of log output is written to OutputDebugString() using msg().
> This makes setup run quite slowly under a debugger.  If you have stdout
> connected to the terminal where your debugger is running (e.g. 'gdb setup'),
> this output is duplicated.
> 
> Future work: there are some other uses of msg() to report real errors.  At the
> moment, these are completely invisible unless you are running setup under a
> debugger.  These should be converted to use the logger.
> 
> 2015-03-02  Jon TURNEY  <...>
> 
> 	* LogFile.cc (endEntry): Remove msg().

Approved, under the assumption that you'll rework the other msg() calls
as well ;)


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

Attachment: pgpkVc3NQNqnb.pgp
Description: PGP signature