Re: [RFC] cygport: use -Werror=implicit-function-declarations

[Corinna Vinschen <corinna-cygwin at cygwin dot com>]

On Oct 16 18:42, Yaakov (Cygwin/X) wrote:
> One of the more common causes of SEGVs with x86_64-cygwin packages
> occurs when an implicit function declaration causes an assumption
> that all arguments and the return value are of type 'int' (32 bits)
> where some or all of these are longs or pointers (64 bits on
> x86_64).  One way of avoiding such errors is to add
> -Werror=implicit-function-declarations to the default
> CFLAGS/OBJCFLAGS, and in my brief testing to date, this has already
> caught a number of cases where this would have broken the package on
> x86_64.
> 
> One potential drawback is that this flag may cause false negatives
> in poorly written configure tests; without extensive testing, I
> can't say yet how prevalent this would be, but I think that making
> this an error and perusing config.log is generally easier than
> making it just a warning and having to sift through the entire
> output of make.

Uh... I'm not so sure about that.  I would rather see the configure
tests running through, but like the idea to have
-Werror=implicit-function-declaration set for the actual make stage.

It's more important that configure tests run to check for existence
of stuff, and not being able to configure is a really annoying
problem.


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

Attachment: pgp_Z9j37X2Dh.pgp
Description: PGP signature