This is the mail archive of the cygwin-apps mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] setup: installed xz packages (was: cygcheck: xz packages)


On Tue, Sep 17, 2013 at 03:09:00PM -0500, Yaakov (Cygwin/X) wrote:
>On 2013-09-16 12:40, Christopher Faylor wrote:
>> On Fri, Sep 13, 2013 at 02:06:19PM -0400, Christopher Faylor wrote:
>>> On Fri, Sep 13, 2013 at 12:10:47PM -0500, Yaakov (Cygwin/X) wrote:
>>>> cygcheck needs fixing wrt .tar.xz packages; patch attached.
>>>
>>> Thanks for noticing this but I think I'd like to see a more general
>>> fix.  In upset, I just completely relaxed the checking of .gz/.bz2/.xz
>>> in favor of just checking for .tar.  So, instead, something like the
>>> below.
>>
>> I just confirmed: It doesn't work.  I did, however, check in a modified
>> version that has the salutary effect of not segv'ing.  It seems to work
>> but, now that I think of it, I haven't downloaded any new packages with
>> .xz extensions.  It is general enough that, if it works for .tar.bz2, it
>> should also work for .tar.xz.
>
>While setup installed .tar.xz packages fine, it turns out they're not 
>being seen as installed the next time setup is run.  Patch attached in 
>your name, since the code is literally a copy of your rewritten 
>winsup/cygwin/dump_setup.cc:find_tar_ext().

Thanks.  Please check in and I'll roll a new setup.exe.

cgf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]