Re: [PATCH 2/2] Add a self-update mechanism for setup.exe

[Dave Korn <dave dot korn dot cygwin at gmail dot com>]

On 02/02/2011 23:24, Jon TURNEY wrote:

> +  /*
> +    XXX: do we need a mechanism for source of setup.exe to be overriden in .ini file
> +    for the benefit of people who use a patched version? Or can they just patch this
> +    as well? :-)
> +  */
> +#define SETUP_URL "http://cygwin.com/setup.exe";

  Why not make that a string resource, like the mirror list is?

> +  for (int i = 1; _argv[i]; i++)
> +    {
> +      newArgs += " ";
> +      newArgs += _argv[i];
> +    }

  Quoting would be needed if any of those are paths containing spaces.

    cheers,
      DaveK