This is the mail archive of the
cygwin-apps
mailing list for the Cygwin project.
Re: [PATCH 5/5] Canonicalize manually added mirror URLs to ensure they end with a '/'
On Tue, Nov 09, 2010 at 01:29:47PM +0000, Jon TURNEY wrote:
>This ensures that the download directory is canonically named with the
>trailing %2f of the url-encoded '/', avoiding downloading everything again
>if the URL varies in the presence of a '/' at the end from last time.
>
>This also prevents a mirror URL being added twice in these two different
>forms.
>
>2010-11-07 Jon TURNEY <jon.turney@dronecode.org.uk>
>
> * site.cc (OnMessageCmd): Canonicalize manually added mirror URLS to
> ensure they end with '/'
Wouldn't it be better to just always strip the trailing '/' when creating the
directory? That would be one less gobbledygook character.
cgf