This is the mail archive of the cygwin-apps mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] inform user if any postinstall script failed to run


On Thu, Aug 12, 2010 at 12:26:33PM +0200, Corinna Vinschen wrote:
>On Aug 12 11:10, Jon TURNEY wrote:
>> On 12/08/2010 06:44, Andy Koppe wrote:
>> >Shall we tone down the error box here a little bit? A postinstall
>> >failure in some obscure package that might only have been installed
>> >due to the user selecting 'All' won't actually impact on the use of
>> >Cygwin. I think the current wording will unnecessarily scare off
>> >unexperienced users who wouldn't know how to correct these failures.
>> >
>> >Suggestion below.
>> >
>> >Andy
>> >
>> >
>> >Index: postinstallresults.cc
>> >===================================================================
>> >RCS file: /cvs/cygwin-apps/setup/postinstallresults.cc,v
>> >retrieving revision 1.1
>> >diff -u -r1.1 postinstallresults.cc
>> >--- postinstallresults.cc       29 Jul 2010 13:09:04 -0000      1.1
>> >+++ postinstallresults.cc       12 Aug 2010 05:39:21 -0000
>> >@@ -57,10 +57,10 @@
>> >    // one or more postinstall scripts failed to run successfully
>> >    // installation may be broken
>> >    MessageBox (NULL,
>> >-              "You will need to investigate and correct these errors "
>> >-              "before your Cygwin installation will function properly.\n"
>> >-              "Check setup.log for details.",
>> >-              "ERROR - postinstall scripts failed",
>> >+              "The affected packages and those that depend\n"
>> >+              "on them may not function properly.\n"
>> >+              "Check /var/log/setup.log for details.",
>> >+              "ERROR - postinstall script failures",
>> >                MB_OK | MB_ICONERROR | MB_SETFOREGROUND | MB_TOPMOST);
>> >
>> >    return IDD_DESKTOP;
>> 
>> I agree, I was going to suggest something like this.  I'm afraid I
>> just copied and adjusted the text from the dependencies declined
>> dialog.
>> 
>> It might be better to point to setup.log.full since it seems that
>> contains the actual output from the failing command, and only from
>> the most recent run of setup.
>
>Yes, that sounds like a good idea to me.

I think that wording will still cause consternation.

Maybe we need something like:

"This does not necessarily mean that the affected package will fail to
function properly but if you do notice problems please check
/var/log/setup.log.full ."

cgf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]