Re: e2fsprogs, e2fsimage

["Gerrit P. Haase" <gp at familiehaase dot de>]

Hello Sam,

> Packages are now available for review at:

Comments inline.

>   http://www.oneparticularharbor.net/cygwin

> e2fsprogs:

>   source :
> http://www.oneparticularharbor.net/cygwin/e2fsprogs/e2fsprogs-1.35-1-src.tar.bz2

Rebuilding works ok.

> http://www.oneparticularharbor.net/cygwin/e2fsprogs/e2fsprogs-1.35-1.tar.bz2

There is an archive included: /usr/lib/libuuid.a
I have already installed: /usr/lib/w32api/libuuid.a
The first will cover the second when no explicit -L flag is used
during linking (both paths are in the default library search list
included).  Would it hurt to put all the libraries into a unique
subdirectory (or several subdirectories)?

I think not a showstopper, though it may cause some complaints about
the stupid linker picking up a wrong library...

When I run badblocks, e2fsck, fsck.ext2, fsck.ext3, mke2fs, mkfs.ext2,
mkfs.ext3 and resize2fs I get an error popup:
'Entry point "GetFileSizeEx" not found in KERNEL32.DLL.'

I'm running NT4 with SP6a.  (See attached screenshot).  Note that this
happens with the binaries compiled here locally.  Is this an error in
the w32api libraries?

Cygwin Package Information
Package              Version        Status
cygwin               1.5.9-1        OK
w32api               2.5-1          OK

Should I upgrade?


> e2fsimage:

>   source :
> http://www.oneparticularharbor.net/cygwin/e2fsimage/e2fsimage-0.2.0-1-src.tar.bz2

$ ./e2fsimage-0.2.0-1.sh all
[...]
e2fsimage-0.2.0/src/uids.c
e2fsimage-0.2.0/src/util.c
patching file e2fsimage-0.2.0/CYGWIN-PATCHES/e2fsimage.README
patching file e2fsimage-0.2.0/CYGWIN-PATCHES/setup.hint
patching file e2fsimage-0.2.0/Local.mak
patching file e2fsimage-0.2.0/configure
patching file e2fsimage-0.2.0/lnconf.sh
patching file e2fsimage-0.2.0/src/Makefile
patching file e2fsimage-0.2.0/src/mke2fs.c
/e2fs/e2fsimage/e2fsimage-0.2.0/lnconf.sh: not found

It is not executable:
$ ls -l /e2fs/e2fsimage/e2fsimage-0.2.0/lnconf.sh
-rw-r--r--    1 gerrit   Domänen-     1683 Aug 10 22:04 /e2fs/e2fsimage/e2fsimage-0.2.0/lnconf.sh

Try this instead of yours:
conf() {
  (cd ${objdir} && \
  sh ${srcdir}/lnconf.sh && \
  CFLAGS="${MY_CFLAGS}" LDFLAGS="${MY_LDFLAGS}" \
  prefix=${prefix} ./configure )
}

>   binary :
> http://www.oneparticularharbor.net/cygwin/e2fsimage/e2fsimage-0.2.0-1.tar.bz2
usr/bin/e2fsimage.exe
usr/man/man1/e2fsimage.1.gz
^^^^^^^
 should be usr/share/man/...

Besides that the packaging looks ok.
Fix the build script and the man location of the e2fsimage package and
it is good to go.


Gerrit
-- 
=^..^=

Attachment: badblocks.JPG
Description: JPEG image