This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: gbs patch (prep/patch)


On Sat, 27 Mar 2004, Marcel Telka wrote:

> Hi.
> Attached is a small patch for gbs' prep command.
>
> ChangeLog entry:
>
> 2004-03-27  Marcel Telka  <marcel@telka.sk>
>
>         * templates/generic-build-script (prep): Apply patch only if it is
>         available.

Marcel,

Thanks for the patch.  However, I'm not sure whether this is the way to
go.  I kinda liked the fact that the maintainer has to provide an empty
patchfile -- it documents the fact that the package builds OOTB, and that
the Cygwin-related patches are folded in.  But I'm willing to hear others'
opinions on this...

Also, in the future, please send the ChangeLog as a separate entry only,
NOT as part of the patch.
	Igor
-- 
				http://cs.nyu.edu/~pechtcha/
      |\      _,,,---,,_		pechtcha@cs.nyu.edu
ZZZzz /,`.-'`'    -.  ;-;;,_		igor@watson.ibm.com
     |,4-  ) )-,_. ,\ (  `'-'		Igor Pechtchanski, Ph.D.
    '---''(_/--'  `-'\_) fL	a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

"I have since come to realize that being between your mentor and his route
to the bathroom is a major career booster."  -- Patrick Naughton


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]