This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [setup PATCH] Rework do_ini [next_dialog removal (2a)]


On Wed, 2003-07-30 at 18:34, Max Bowsher wrote:

> This is just as well, since currently if IDD_S_LOAD_INI does got posted back
> to threebar.cc, setup hangs on the progress page, since do_fromcwd does not
> do what the code in threebar.cc seems to believe it does.
> 
> So, I'm adding an exit in a very narrow edge case (and the exit is
> implicitly a "FIXME: Use an Exception").

Ok, that makes sense. Please make a small note in the code - "TODO,
return to do_local_ini / the source selection screen", and also make it
with //FIXME: throw an exception".

Do those two things, and it's approved.

Cheers,
Rob

-- 
GPG key available at: http://members.aardvark.net.au/lifeless/keys.txt.
---

Attachment: signature.asc
Description: This is a digitally signed message part


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]