This is the mail archive of the
cygwin-apps@cygwin.com
mailing list for the Cygwin project.
Re: Curious code in Installer::installOneSource
- From: Igor Pechtchanski <pechtcha at cs dot nyu dot edu>
- To: Max Bowsher <maxb at ukf dot net>
- Cc: cygwin-apps at cygwin dot com
- Date: Sat, 5 Apr 2003 18:12:09 -0500 (EST)
- Subject: Re: Curious code in Installer::installOneSource
- Reply-to: cygwin-apps at cygwin dot com
On Sat, 5 Apr 2003, Max Bowsher wrote:
> I'm working in this area to implement the MD5-on-install feature. Is there
> any reason why I should not simplify this:
>
> char msg[64];
> strcpy (msg, "Installing");
> Progress.SetText1 (msg);
> log (LOG_PLAIN, String (msg) + " " + source.Cached ());
>
> To this:
> char msg[] = "Installing";
> Progress.SetText1 (msg);
> log (LOG_PLAIN, String (msg) + " " + source.Cached ());
>
> Or even, this:
> Progress.SetText1 ("Installing");
> log (LOG_PLAIN, String ("Installing ") + source.Cached ());
>
> (There is no other use of the msg variable outside the context shown here.)
> Max.
Max,
Normally I would argue for a #define (using the "Redundancy leads to
inconsistency" principle), but in this case the two uses seem to be
completely independent, so I think your last suggestion is ok.
Igor
--
http://cs.nyu.edu/~pechtcha/
|\ _,,,---,,_ pechtcha at cs dot nyu dot edu
ZZZzz /,`.-'`' -. ;-;;,_ igor at watson dot ibm dot com
|,4- ) )-,_. ,\ ( `'-' Igor Pechtchanski
'---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow!
Knowledge is an unending adventure at the edge of uncertainty.
-- Leto II