Re: [PATCH] debug/gdb: include expat for gdb-cross

["Yann E. MORIN" <yann dot morin dot 1998 at free dot fr>]

Trevor, All,

On Saturday 02 March 2013 Trevor Woerner wrote:
> # HG changeset patch
> # User Trevor Woerner <twoerner@gmail.com>
> # Date 1362239822 18000
> # Node ID bfbfdaaea8592dd87f96ddea8637f5b17b194ad4
> # Parent  f89f8e6f876679184acb66ea642e42c9e7cf2f44
> debug/gdb: include expat for gdb-cross
> 
> Some boards, such as the ST Discovery, have a debugger interface which
> can be queried for a device feature description which is provided in XML.
> Therefore it would be nice to have expat available to make use of this
> information.
> 
> Signed-off-by: Trevor Woerner <twoerner@gmail.com>
> 
> diff -r f89f8e6f8766 -r bfbfdaaea859 scripts/build/debug/300-gdb.sh
> --- a/scripts/build/debug/300-gdb.sh	Mon Feb 25 21:19:31 2013 +0100
> +++ b/scripts/build/debug/300-gdb.sh	Sat Mar 02 10:57:02 2013 -0500
> @@ -16,6 +16,7 @@
>  
>      if [ "${CT_GDB_CROSS}" = y ]; then
>          do_gdb=y
> +        do_expat=y
>      fi

This is wrong:
  - 'do_expat' is used to detect whether the expat lib shall be downloaded
    and extracted;
  - 'do_expat' is then mis-used:
    - it is never used to build expat for the host, but is used to decide
      whether to enable/disable expat in the cross-gdb
    - it is used to decide whether to build expat for the target, but is
      always set when the native-gdb is selected, so the check is pointless.

What should be done is:
  - rename 'do_expat' to 'need_expat' (ditto for 'do_ncurses')
  - use 'need_expat' only to decide whether to download/extract libexpat
  - cross-gdb: always enable expat support
  - native-gdb: ditto

I'm on it. Thanks for the report! :-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

--
For unsubscribe information see http://sourceware.org/lists.html#faq