Re: [PATCH] libc/eglibc: add an option to enable obsolete RPC building

[Bryan Hundven <bryanhundven at gmail dot com>]

On Wed, Oct 17, 2012 at 4:43 AM, Florian Fainelli <f.fainelli@gmail.com> wrote:
> # HG changeset patch
> # User Florian Fainelli <f.fainelli@gmail.com>
> # Date 1349256753 -7200
> # Node ID 7f6ddb2b0ca0d89fa5bc98c1deb55d840b505ccd
> # Parent  43ace4bb005eef085437e3d4fbaef528ef0ef005
> [PATCH] libc/eglibc: add an option to enable obsolete RPC building
>
> Add an option to enable eglibc's feature to build the obsolete RPC
> implementation, which is selected by default when eglibc 2.16 is selected.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>
> diff --git a/config/libc/eglibc.in b/config/libc/eglibc.in
> --- a/config/libc/eglibc.in
> +++ b/config/libc/eglibc.in
> @@ -197,6 +197,15 @@
>        Optimize eglibc for size using -Os instead of -O2. This will make eglibc
>        smaller but may make it slower.
>
> +config EGLIBC_ENABLE_OBSOLETE_RPC
> +    bool
> +    prompt "Enable obsolete RPC"
> +    default y if LIBC_EGLIBC_V_2_16
> +    help
> +      Enable the building of the pre eglibc 2.14 RPC implementation.
> +      This option may be required if you are not building libtirpc for
> +      your system.
> +
>  config EGLIBC_CUSTOM_CONFIG
>      bool
>      prompt "Use custom configuration file"
> diff --git a/scripts/build/libc/glibc-eglibc.sh-common b/scripts/build/libc/glibc-eglibc.sh-common
> --- a/scripts/build/libc/glibc-eglibc.sh-common
> +++ b/scripts/build/libc/glibc-eglibc.sh-common
> @@ -214,6 +214,9 @@
>              else
>                  OPTIMIZE=-O2
>              fi
> +            if [ "${CT_EGLIBC_ENABLE_OBSOLETE_RPC}" = "y" ]; then
> +                extra_config+=( --enable-obsolete-rpc )
> +            fi
>              ;;
>          glibc)
>              # glibc can't be built without -O2 (reference needed!)
> exporting patch:
> <fdopen>
>
>
> --
> For unsubscribe information see http://sourceware.org/lists.html#faq
>

Florian,

Wouldn't this affect glibc-2.16 as well? In that case, it maybe better
to put this in glibc-eglibc.sh-common, so when glibc-2.16 is added to
ct-ng, it will just work (famous last words).

-Bryan

--
For unsubscribe information see http://sourceware.org/lists.html#faq