Re: [PATCH 1/3] Split changeset 3052:06b663f297 into eglibc/libc and eglibc/ports patches

["Yann E. MORIN" <yann dot morin dot 1998 at free dot fr>]

Florian, Bongseo, All,

On Saturday 22 September 2012 19:59:50 Florian Fainelli wrote:
> Le 22/09/2012 10:27, Bongseo Jang a Ãcrit :
> > Hi, All
> >
> > Finding "patches/eglibc/2_16: backport OpenEmbedded patches for eglibc
> > 2.16" didn't go well with crosstoo-ng in its own,
> > I splited them eglibc/libc and egblibc/ports own
> 
> What was wrong with the patches exactly? It seems to me like they were 
> made to be applied with patch -p1, and you are removing a directory 
> level with your change.

Indeed, in the state, the patches do not apply.

That's because the patches are done against the 'root' of the eglibc
repository, while crosstool-NG exepects them to be from the libc/ sub-dir.

In fact, the libc/ sub-dir in glibc (note, glibc, not eglibc!) is what
is used to make the glibc releases. So for eglibc, ct-ng also considers
libc/ to be the eglibc 'root', and patches are made against this directory
(in -p1 format, of course).

So, Bongseo's patch are right (except they were totally mangled by his/her
mailer).

My bad, I missed that before applying, and should have checked they did
at least apply. Bitten once, not twice! :-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

--
For unsubscribe information see http://sourceware.org/lists.html#faq