Re: [nls PATCH 2 of 3] binutils/binutils: Handle --disable-nls config

[Michael Hope <michael dot hope at linaro dot org>]

On Wed, Nov 23, 2011 at 6:23 AM, Yann E. MORIN
<yann.morin.1998@anciens.enib.fr> wrote:
> Zhenqiang, All,
>
> On Tuesday 22 November 2011 12:53:42 Zhenqiang Chen wrote:
>> # HG changeset patch
>> # User Zhenqiang Chen <zhenqiang.chen@linaro.org>
>> # Date 1321523984 -28800
>> # Node ID 640bdfd7d1efc1b91ad54304fefe6db77179ec65
>> # Parent ?986e1c75432aad60ae3239767198c653c08c01af
>> binutils/binutils: Add --disable-nls config when
>> option "Enable nls" is not selected.
>>
>> Reviewed-by: Michael Hope
>> Signed-off-by: Zhenqiang Chen <zhenqiang.chen@linaro.org>
>>
>> diff --git a/scripts/build/binutils/binutils.sh b/scripts/build/binutils/binutils.sh
>> --- a/scripts/build/binutils/binutils.sh
>> +++ b/scripts/build/binutils/binutils.sh
>> @@ -62,6 +62,8 @@
>> ? ? ? ? ? [ -n "${CT_TOOLCHAIN_BUGURL}" ] && extra_config+=("--with-bugurl=${CT_TOOLCHAIN_BUGURL}")
>> ? ? ? fi
>>
>> + ? ?[ "${CT_TOOLCHAIN_ENABLE_NLS}" != "y" ] && extra_config+=("--disable-nls")
>
> Shoudn't we also force --enable-nls otherwise?

NLS is on by default and has to be explicitly turned off using
--disable-nls.  See binutils/config/nls.m4:

  AC_ARG_ENABLE(nls,
    [  --disable-nls           do not use Native Language Support],
    USE_NLS=$enableval, USE_NLS=yes)

-- Michael

--
For unsubscribe information see http://sourceware.org/lists.html#faq