Re: [PATCH] scripts: support an empty vendor string

[Michael Hope <michael dot hope at linaro dot org>]

On Wed, Oct 19, 2011 at 7:18 PM, Bryan Hundven <bryanhundven@gmail.com> wrote:
> On Tue, Oct 18, 2011 at 8:24 PM, Michael Hope <michael.hope@linaro.org> wrote:
>> # HG changeset patch
>> # User Michael Hope <michael.hope@linaro.org>
>> # Date 1318994616 -46800
>> # Node ID 5b1330e7264a72b0b50243394469606ef0f76351
>> # Parent ?a31d097e28cd73d07a5484129929a500b4d58efa
>> scripts: support an empty vendor string
>>
>> For Linux and other targets, config.sub defaults to 'unknown'
>> if no vendor was specified. ?This patch supplies a fake vendor and
>> then strips it out afterwards.
>>
>> This is needed to have an Ubuntu style vendorless tuple such as
>> arm-linux-gnueabi. ?Other features like the alias and sed transform
>> don't cover it.
>>
>> Signed-off-by: Michael Hope <michael.hope@linaro.org>
>>
>
> imo, this functionality should be optional to:
> ? Allow empty vendor string (enabled)
> or
> ? revert to the previous default of 'unknown'. (disabled)
>
> I think some components that crosstool-ng builds depend on having
> a vendor string.
>
> http://sourceware.org/cgi-bin/search.cgi?q=vendor&cmd=Search%21&form=extended&m=all&ps=10&fmt=long&wm=wrd&sp=1&sy=1&wf=2221&type=&GroupBySite=no&ul=%2Fml%2Fcrossgcc%2F%25
>
> or
>
> http://goo.gl/BFVyU
>
> My only real reference there was the uClibc vendor string problem,
> so if ! LIBC_UCLIBC_CONFIG_FILE(or any better test), then this
> option can be enabled, otherwise revert to current default.
>
> The other side of the idea is support older configurations, as users
> move to newer versions of ctng, their configs will still build and work.
> If they did before. You obviously know you want this option and will
> enable it in your config. :-)

Good point.  config/toolchain.in defaults to "unknown" and most of the
samples are the same but sh4-unknown-linux-gnu,
powerpc-unknown-linux-gnu, and powerpc64-unknown-linux-gnu all use an
empty string.

-- Michael

--
For unsubscribe information see http://sourceware.org/lists.html#faq