Re: [PATCH 1 of 2] kconfig: add version helpers

[BenoÃt THÃBAUDEAU <benoit dot thebaudeau at advansee dot com>]

Yann, all,


> script --> patch. ;-)

OK.

> 'default n' is unneeded, it is the default.

Yes. I only put that to do the same as for CC_GCC_x_y_or_later in gcc.in.

> This scheme does not work when a newer version ceases to support a
> feature
> of older versions. The way I've been going with gcc is to have a kind
> of
> 'version familly' that selects the supported features, plus the
> _or_later
> stuff.
>
> Eg.:
>
> config BINUTILS_HAS_PKG_VERSION_BUGURL
>     bool
>
> config BINUTILS_2_20_or_later
>     bool
>     default n
>     select BINUTILS_HAS_PKG_VERSION_BUGURL
>
> And then in the script:
>
> if [ "${CT_BINUTILS_HAS_PKG_VERSION_BUGURL}" = "y" ]; then
>     foo bar
> fi
>
> This is more explicit, I think.

OK. I can do that.

> And what about glibc?

I have looked for these options in all the glibc versions supported by
CT-NG, but they do not seem to be supported.

> Code duplication, please make it a function that does the split...
> ... and use it here and everywhere we need to split ${version}...
> ... here for example.

OK.

Regards,
BenoÃt

--
For unsubscribe information see http://sourceware.org/lists.html#faq