Re: [PATCH 1 of 2] cross-gdb: add XML support

["Yann E. MORIN" <yann dot morin dot 1998 at anciens dot enib dot fr>]

Benoit, All,

On Tuesday 24 May 2011 13:20:45 BenoÃt THÃBAUDEAU wrote:
> # HG changeset patch
> # User "BenoÃt THÃBAUDEAU" <benoit.thebaudeau@advansee.com>
> # Date 1306235318 -7200
> # Node ID 420687b63c9775201e84e40f76b4c176996e3bda
> # Parent  230d50dd23230a2b09fb390d771f5628a1c7342f
> cross-gdb: add XML support
> 
> This patch adds XML support to cross-gdb so that the target description can be
> parsed. This avoids possible runtime malfunctions, and the following GDB warning:
> "Can not parse XML target description; XML support was disabled at compile time"

I am not too fond of this patch for two reasons:

1) libexpat should be provided by the host:
   - in case of cross-compilation, it should be installed on your distro.
     If you want a static gdb, then also install the -dev package from your
     distro;
   - in case of canadian-cross, your upper-layer build-system should install
     libexpat itself.

  Note that the companion libraries are a bit special, as, until recently,
  distros were not shipping them, or were shipping out-dated versions. This
  is not the case for libexpat.

2) code duplication to build libexpat
   - at least, provide a function that build libexpat, and takes as
     arguments: prefix, build and host
   - better yet, include it in the companion libraries infrastructure,
     even if there is no option and no version selection.

But again, I am not really inclined to accept such a change, as explained
above...

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

--
For unsubscribe information see http://sourceware.org/lists.html#faq