CT-NG 1.11.1: Using Spaces in *_EXTRA_CONFIG

[Ben Baattheid <ben dot baattheid at gmail dot com>]

Hi all,

I have an issue with crosstool-NG 1.11.1: When spaces are used for
parameters inside *_EXTRA_CONFIG, the corresponding configure commands
fail.

This is the same problem as in
http://sourceware.org/ml/crossgcc/2010-08/msg00186.html, which
actually was a quoting issue. Indeed, for Linaro GCC, the --with-specs
option exists and nonetheless gives the same errors, depending on the
quoting choice. But there is also an issue with other options, like
--with-pkgversion which is not automatically passed by CT-NG to
configure for binutils and libc (same for --with-bugurl), which
requires the use of *_EXTRA_CONFIG.

For instance, with binutils:


CT_BINUTILS_EXTRA_CONFIG="\"--with-pkgversion=${CT_CC_PKGVERSION}\"
\"--with-bugurl=${CT_CC_BUGURL}\"" in .config produces:

[DEBUG]    ==> Executing: 'CFLAGS= -pipe'
'/test/.build/src/binutils-2.20.1/configure'
'--build=i686-build_pc-linux-gnu' '--host=i686-build_pc-linux-gnu'
'--target=arm-test-linux-gnueabi'
'--prefix=/opt/x-tools/arm-test-linux-gnueabi' '--disable-nls'
'--disable-multilib' '--disable-werror' '--with-float=soft'
'"--with-pkgversion=Linaro' '4.5-2011.04-0"'
'"--with-bugurl=http://www.test.com/";'
'--with-sysroot=/opt/x-tools/arm-test-linux-gnueabi/arm-test-linux-gnueabi/libc'
[ERROR]    configure: error: invalid variable name: `"--with-pkgversion'


CT_BINUTILS_EXTRA_CONFIG="'--with-pkgversion=${CT_CC_PKGVERSION}'
'--with-bugurl=${CT_CC_BUGURL}'" in .config produces:

[DEBUG]    ==> Executing: 'CFLAGS= -pipe'
'/test/.build/src/binutils-2.20.1/configure'
'--build=i686-build_pc-linux-gnu' '--host=i686-build_pc-linux-gnu'
'--target=arm-test-linux-gnueabi'
'--prefix=/opt/x-tools/arm-test-linux-gnueabi' '--disable-nls'
'--disable-multilib' '--disable-werror' '--with-float=soft'
''--with-pkgversion=Linaro' '4.5-2011.04-0''
''--with-bugurl=http://www.test.com/''
'--with-sysroot=/opt/x-tools/arm-test-linux-gnueabi/arm-test-linux-gnueabi/libc'
[ERROR]    configure: error: invalid variable name: `'--with-pkgversion'


CT_BINUTILS_EXTRA_CONFIG="--with-pkgversion=\"${CT_CC_PKGVERSION}\"
--with-bugurl=\"${CT_CC_BUGURL}\"" in .config produces:

[DEBUG]    ==> Executing: 'CFLAGS= -pipe'
'/test/.build/src/binutils-2.20.1/configure'
'--build=i686-build_pc-linux-gnu' '--host=i686-build_pc-linux-gnu'
'--target=arm-test-linux-gnueabi'
'--prefix=/opt/x-tools/arm-test-linux-gnueabi' '--disable-nls'
'--disable-multilib' '--disable-werror' '--with-float=soft'
'--with-pkgversion="Linaro' '4.5-2011.04-0"'
'--with-bugurl="http://www.test.com/";'
[...]
[ALL  ]    /bin/bash: line 4: 4.5-2011.04-0
--with-bugurl=http://www.test.com/
--with-sysroot=/opt/x-tools/arm-test-linux-gnueabi/arm-test-linux-gnueabi/libc:
No such file or directory
[ALL  ]    /bin/bash: line 4: 4.5-2011.04-0
--with-bugurl=http://www.test.com/
--with-sysroot=/opt/x-tools/arm-test-linux-gnueabi/arm-test-linux-gnueabi/libc:
No such file or directory


CT_BINUTILS_EXTRA_CONFIG="--with-pkgversion='${CT_CC_PKGVERSION}'
--with-bugurl='${CT_CC_BUGURL}'" dans .config donne :

[DEBUG]    ==> Executing: 'CFLAGS= -pipe'
'/test/.build/src/binutils-2.20.1/configure'
'--build=i686-build_pc-linux-gnu' '--host=i686-build_pc-linux-gnu'
'--target=arm-test-linux-gnueabi'
'--prefix=/opt/x-tools/arm-test-linux-gnueabi' '--disable-nls'
'--disable-multilib' '--disable-werror' '--with-float=soft'
'--with-pkgversion='Linaro' '4.5-2011.04-0''
'--with-bugurl='http://www.test.com/''
[...] then
[ALL  ]    /bin/bash: line 4: 4.5-2011.04-0
--with-bugurl=http://www.test.com/
--with-sysroot=/opt/x-tools/arm-test-linux-gnueabi/arm-test-linux-gnueabi/libc:
No such file or directory
[ALL  ]    /bin/bash: line 4: 4.5-2011.04-0
--with-bugurl=http://www.test.com/
--with-sysroot=/opt/x-tools/arm-test-linux-gnueabi/arm-test-linux-gnueabi/libc:
No such file or directory


As you can see, the --with-pkgversion option gets split in all cases
because of the space, independently of the quoting choice, which
breeds the errors.

Thanks in advance for your support.

Best regards,
Ben

--
For unsubscribe information see http://sourceware.org/lists.html#faq