Re: gcc build breaks when . in PATH

[Marc Kleine-Budde <mkl at pengutronix dot de>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Marc Kleine-Budde wrote:
> Johannes Stezenbach wrote:
>> Hi,
> 
>> while testing arm-uClibc-NPTL build on an older machine
>> I found that including . in PATH causes build breakage in the
>> cc_core_pass_1 step (with gcc-4.4.4):
> 
>> [ALL  ]    checking what assembler to use... /tmp/build/targets/arm-unknown-linux-uclibcgnueabi/build/gcc-core-static/arm-unknown-linux-uclibcgnueabi/bin/as
>> ...
>> [ALL  ]    config.status: creating as
> 
> 
>> i.e. "as" is supposed to be the arm-unknown-linux-uclibcgnueabi cross assembler,
>> but config.status creates a local "as" script which is calling the
>> host assembler.
> 
> 
>> It might be a good idea to add a check for . in PATH in
>> crosstool-NG's "Performing some trivial sanity checks" step?
> 
> ptxdist does this:
> PATH="$(echo $PATH | sed -e "s/:\.$//" -e "s/^\.://" -e "s/:\.://")"
> 
> the sed expression is not optimal and can be simplified :)

...and is buggy :P This isn't optimal, but works quite good:

echo .:/foo:.:/bar:.:/baz:. |
	sed -e "s/:\.:/:/g" -e "s/:\.$//" -e "s/^\.://"
/foo:/bar:/baz

But not if the user pushes it :(

echo .:/foo:.:/bar:.:.:/baz:. |
	sed -e "s/:\.:/:/g" -e "s/:\.$//" -e "s/^\.://"

/foo:/bar:.:/baz

Marc

- --
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkw9u7YACgkQjTAFq1RaXHNbPgCeOBej0y7/fdFxvdYWVZhX1xJ+
yq8An0eVq4QTU6nDTEH2sXg834XDiHn2
=pVe4
-----END PGP SIGNATURE-----

--
For unsubscribe information see http://sourceware.org/lists.html#faq