Re: [PATCH 2/4] gcc-4.4 does not depend on MPC, only gcc-4.5 does

[Johannes Stezenbach <js at sig21 dot net>]

On Fri, Jul 09, 2010 at 10:01:16PM +0200, Yann E. MORIN wrote:
> Johannes, All,
> 
> On Friday 09 July 2010 15:53:00 Johannes Stezenbach wrote:
> > gcc-4.4 does not depend on MPC, only gcc-4.5 does
> 
> The ./configure for gcc-4.4 does indeed accept --with-mpc, which 
> leads me to think that it can use it.
> 
> I'll try to build a shared-linked gcc this WE to see if it does indeed
> has a runtime dependency against it, and see what symbols it uses.
> If it turns out that gcc calls no MPC symbols, then we'll remove it.

Hm, maybe MPC is optional for gcc-4.4, it is listed as
a new prerequisite for gcc-4.5:
http://gcc.gnu.org/gcc-4.5/changes.html

> > -config CC_GCC_USE_PPL_CLOOG_MPC
> > - ? ?bool
> > - ? ?default n
> > - ? ?select PPL
> > - ? ?select CLOOG
> > - ? ?select MPC
> 
> If, and I say _if_, gcc does not use MPC, then why not just rename this
> config option and the following, move the "select MPC" down, like:
> 
>   config CC_GCC_4_4_or_later
>     select CC_GCC_USE_PPL_CLOOG
> 
>   config CC_GCC_4_5_or_later
>     select CC_GCC_USE_MPC_ELF
> 
>   config CC_GCC_USE_PPL_CLOOG
>     blabla
> 
>   config CC_GCC_USE_MPC_LIBELF
>     blabla
> 
> and adapt the code in scripts/build/cc/gcc.sh accordingly? That'd be much
> cleaner in the end.
> 
> Besides, your patch is wrong because the build script *will* try to call
> gcc's ./configure with --with-mpc, as the code is not based on per-lib, but
> is baased on the global options.

Yeah, seems I didn't get the logic of the CC_GCC_USE_PPL_CLOOG_MPC
config option in conjunction with scripts/build/cc/gcc.sh.
I guess --with-mpc was ignored by configure since it didn't find MPC,
so I didn't notice my mistake.


Thanks
Johannes

--
For unsubscribe information see http://sourceware.org/lists.html#faq