Re: [PATCH 2/4] gcc-4.4 does not depend on MPC, only gcc-4.5 does

["Yann E. MORIN" <yann dot morin dot 1998 at anciens dot enib dot fr>]

Johannes, All,

On Friday 09 July 2010 15:53:00 Johannes Stezenbach wrote:
> gcc-4.4 does not depend on MPC, only gcc-4.5 does

The ./configure for gcc-4.4 does indeed accept --with-mpc, which 
leads me to think that it can use it.

I'll try to build a shared-linked gcc this WE to see if it does indeed
has a runtime dependency against it, and see what symbols it uses.
If it turns out that gcc calls no MPC symbols, then we'll remove it.

> diff -r d02fbe929dc0 -r 2c95d7abdf73 config/cc/gcc.in
> --- a/config/cc/gcc.in??Fri Jun 25 10:14:04 2010 +0200
> +++ b/config/cc/gcc.in??Fri Jun 25 11:02:41 2010 +0200
> @@ -131,7 +131,8 @@
> ? ? ?default n
> ? ? ?select CC_GCC_4_3_or_later
> ? ? ?select CC_GCC_4_2_or_later
> - ? ?select CC_GCC_USE_PPL_CLOOG_MPC
> + ? ?select PPL
> + ? ?select CLOOG
> ?
> ?config CC_GCC_4_5_or_later
> ? ? ?bool
> @@ -140,6 +141,7 @@
> ? ? ?select CC_GCC_4_3_or_later
> ? ? ?select CC_GCC_4_2_or_later
> ? ? ?select CC_GCC_USE_LIBELF
> + ? ?select MPC
> ?
> ?config CC_GCC_USE_GMP_MPFR
> ? ? ?bool
> @@ -147,13 +149,6 @@
> ? ? ?select GMP
> ? ? ?select MPFR
> ?
> -config CC_GCC_USE_PPL_CLOOG_MPC
> - ? ?bool
> - ? ?default n
> - ? ?select PPL
> - ? ?select CLOOG
> - ? ?select MPC

If, and I say _if_, gcc does not use MPC, then why not just rename this
config option and the following, move the "select MPC" down, like:

  config CC_GCC_4_4_or_later
    select CC_GCC_USE_PPL_CLOOG

  config CC_GCC_4_5_or_later
    select CC_GCC_USE_MPC_ELF

  config CC_GCC_USE_PPL_CLOOG
    blabla

  config CC_GCC_USE_MPC_LIBELF
    blabla

and adapt the code in scripts/build/cc/gcc.sh accordingly? That'd be much
cleaner in the end.

Besides, your patch is wrong because the build script *will* try to call
gcc's ./configure with --with-mpc, as the code is not based on per-lib, but
is baased on the global options.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'



--
For unsubscribe information see http://sourceware.org/lists.html#faq