This is the mail archive of the crossgcc@sourceware.org mailing list for the crossgcc project.

See the CrossGCC FAQ for lots more information.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1 of 8] docs/kconfig.mk: Use ncurses from macports on MacOS


Titus, All,

On Saturday 22 May 2010 20:19:13 Titus von Boxberg wrote:
> Am 22.05.2010 um 17:55 schrieb Yann E. MORIN:
> > We already have check-lxdialog.sh that gives the CFLAGS and LDFLAGS.
> > Better update the script, so everything is in a single place.
> Currently, check-lxdialog.sh is orphaned, yes?

No it's not. From kconfig/kconfig.mk@74:
  # Compiler and linker flags to use ncurses
  NCURSES_CFLAGS = $(shell $(SHELL) $(check_lxdialog) -ccflags)
  NCURSES_LDFLAGS = $(shell $(SHELL) $(check_lxdialog) -ldflags $(HOST_CC) ...
                                 ... $(LX_FLAGS) $(EXTRA_CFLAGS))

Then NCURSES_CFLAGS gets used to build mconf.

> At least -check does not work on my system and I cannot find a caller of it.

No, there's no caller for -check, but we do use -cflags and -ldflags.

> Then, also
> has_or_abort inc="ncurses/ncurses.h ncurses/curses.h ncurses.h curses.h"    \
>              err="'ncurses' headers files were not found"
> in configure should be rewritten using check_lxdialog.sh -check, yes?

Yes, it should, not with -check, but with -cflags and -ldflags.

But in this case, it would be redundant to compute that again at runtime.
So we could detect proper ncurses CFLAGS and LDFLAGS during ./configure,
and propagate them down to the kconfig stuff.

Or keep it as it's now, just adding the check during ./configure, but that'd
require a small note in both files, stating the cross-reference.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'



--
For unsubscribe information see http://sourceware.org/lists.html#faq


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]