This is the mail archive of the crossgcc@sources.redhat.com mailing list for the crossgcc project.

See the CrossGCC FAQ for lots more information.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

glibc addon bug


Hi,

I think that there is a problem with the patch logic in getandpatch.sh in crosstool-0.28-rc23 which happens on all runs of all.sh after the first one. Note that this happens when SRC_DIR is set to a directory other than the default BUILD_DIR, if SRC_DIR is the same as BUILD_DIR all the unpacked sources get deleted each time.

This is because the logic in getandpatch.sh doesn't detect that any glibc addons have been previously unpacked and patched, and tries to repeat the operations which end in the patches failing.

I've attached a patch which fixes this problem by checking for the presence of the addon directory in the glibc directory.

- Steve




--- crosstool-0.28rc23/getandpatch.sh	2004-05-31 22:51:53.000000000 +0100
+++ crosstool-0.28rc23.modified/getandpatch.sh	2004-06-16 16:28:37.000000000 +0100
@@ -85,7 +85,11 @@
     cd $SRC_DIR
 
     case $ARCHIVE_NAME in
-    glibc-*-2.*) echo "It's a glibc addon, so cd into glibc"; cd $GLIBC_DIR ;;
+    glibc-*-2.*)
+        echo "It's a glibc addon, test whether it exists"
+        GLIBC_ADDON=`echo ${BASENAME} | cut -d- -f2`
+        test -d ${SRC_DIR}/${GLIBC_DIR}/${GLIBC_ADDON} && { echo "directory ${GLIBC_ADDON} already present"; return 0 ; }
+        echo "It's a glibc addon, & doesn\'t exist, so cd into glibc"; cd $GLIBC_DIR ;;
     *) ;;
     esac
 

------
Want more information?  See the CrossGCC FAQ, http://www.objsw.com/CrossGCC/
Want to unsubscribe? Send a note to crossgcc-unsubscribe@sources.redhat.com

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]