This is the mail archive of the
cluster-cvs@sourceware.org
mailing list for the cluster.
gfs2-utils: master - gfs2_edit: Indirect pointers missing from listwhen paging up and down
- From: Bob Peterson <rpeterso at fedoraproject dot org>
- To: cluster-cvs-relay at redhat dot com
- Date: Mon, 31 Aug 2009 17:32:17 +0000 (UTC)
- Subject: gfs2-utils: master - gfs2_edit: Indirect pointers missing from listwhen paging up and down
Gitweb: http://git.fedorahosted.org/git/gfs2-utils.git?p=gfs2-utils.git;a=commitdiff;h=f2c6bd843a39c145277243a0240a219bbee40c77
Commit: f2c6bd843a39c145277243a0240a219bbee40c77
Parent: f49b4f3bfdccc8489fbeebe4a059ef1e3629a38e
Author: Bob Peterson <bob@ganesha.peterson>
AuthorDate: Mon Aug 31 11:24:23 2009 -0500
Committer: Bob Peterson <rpeterso@redhat.com>
CommitterDate: Mon Aug 31 12:31:24 2009 -0500
gfs2_edit: Indirect pointers missing from list when paging up and down
When using page-up and page-down to scroll a list of indirect
block pointers, there was sometimes an occasional gap due to
incorrect end-of-line management.
rhbz#503529
---
gfs2/edit/hexedit.c | 7 ++-----
1 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/gfs2/edit/hexedit.c b/gfs2/edit/hexedit.c
index c99c2c6..5a506a9 100644
--- a/gfs2/edit/hexedit.c
+++ b/gfs2/edit/hexedit.c
@@ -1291,8 +1291,6 @@ static int display_indirect(struct iinfo *ind, int indblocks, int level, uint64_
int offsets[5];
last_entry_onscreen[dmode] = 0;
- if (!level)
- eol(0);
if (!has_indirect_blocks())
return -1;
if (!level) {
@@ -1308,7 +1306,6 @@ static int display_indirect(struct iinfo *ind, int indblocks, int level, uint64_
print_gfs2("This indirect block contains %d indirect blocks",
indblocks);
}
- eol(0);
total_dirents = 0;
/* Figure out multiplication factors for indirect pointers. */
if (!S_ISDIR(di.di_mode)) {
@@ -1342,9 +1339,9 @@ static int display_indirect(struct iinfo *ind, int indblocks, int level, uint64_
factor[i + 1] = factor[i] * inptrs;
}
if (!level)
- print_gfs2(" (at height=%d)", cur_height);
- eol(0);
+ print_gfs2(" (at height %d)", cur_height);
}
+ eol(0);
if (!level && indblocks) {
print_gfs2("Indirect blocks:");
eol(0);