This is the mail archive of the cluster-cvs@sourceware.org mailing list for the cluster.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

cluster: STABLE3 - gfs_fsck: Segfault in EA leaf repair


Gitweb:        http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=7e29854c15d5f0f0968f3a2e3728643caeec92ae
Commit:        7e29854c15d5f0f0968f3a2e3728643caeec92ae
Parent:        ac92e41653e6a0361168e2b80daee8ede2f21750
Author:        Bob Peterson <rpeterso@redhat.com>
AuthorDate:    Wed Jul 1 14:34:17 2009 -0500
Committer:     Bob Peterson <rpeterso@redhat.com>
CommitterDate: Wed Jul 1 14:38:07 2009 -0500

gfs_fsck: Segfault in EA leaf repair

bz 495774 / 507775
---
 gfs/gfs_fsck/metawalk.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/gfs/gfs_fsck/metawalk.c b/gfs/gfs_fsck/metawalk.c
index 104ab7e..b797cca 100644
--- a/gfs/gfs_fsck/metawalk.c
+++ b/gfs/gfs_fsck/metawalk.c
@@ -411,10 +411,11 @@ static int check_leaf_eattr(struct fsck_inode *ip, uint64_t block,
 			relse_buf(ip->i_sbd, bh);
 			return 1;
 		}
-		check_eattr_entries(ip, bh, pass);
-
-		if (bh)
+		if (bh) {
+			error = check_eattr_entries(ip, bh, pass);
 			relse_buf(ip->i_sbd, bh);
+		}
+		return error;
 	}
 
 	return 0;


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]