This is the mail archive of the
cluster-cvs@sourceware.org
mailing list for the cluster.
cluster: STABLE3 - rgmanager: Don't push NULL on to the S/Lang stack
- From: Lon Hohberger <lon at fedoraproject dot org>
- To: cluster-cvs-relay at redhat dot com
- Date: Mon, 22 Jun 2009 18:24:04 +0000 (UTC)
- Subject: cluster: STABLE3 - rgmanager: Don't push NULL on to the S/Lang stack
Gitweb: http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=f2840814ddf827d84cb0134fa7b7d4bd07c5ef9e
Commit: f2840814ddf827d84cb0134fa7b7d4bd07c5ef9e
Parent: 6c7d63d837b04470ebfadfd390c7ce7ec8d75010
Author: Lon Hohberger <lhh@redhat.com>
AuthorDate: Mon Jun 22 14:14:53 2009 -0400
Committer: Lon Hohberger <lhh@redhat.com>
CommitterDate: Mon Jun 22 14:24:01 2009 -0400
rgmanager: Don't push NULL on to the S/Lang stack
Signed-off-by: Lon Hohberger <lhh@redhat.com>
---
rgmanager/src/daemons/slang_event.c | 9 ++++++++-
1 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/rgmanager/src/daemons/slang_event.c b/rgmanager/src/daemons/slang_event.c
index 3f93039..aa93abd 100644
--- a/rgmanager/src/daemons/slang_event.c
+++ b/rgmanager/src/daemons/slang_event.c
@@ -424,8 +424,15 @@ sl_service_property(char *svcName, char *prop)
if (get_service_property(svcName, prop, buf, sizeof(buf)) < 0)
return;
- /* does this work or do I have to push a malloce'd string? */
ret = strdup(buf);
+ if (!ret) {
+ SLang_verror(SL_RunTime_Error,
+ (char *)"%s: Failed to duplicate state of %s",
+ __FUNCTION__,
+ svcName);
+ return;
+ }
+
if (SLang_push_malloced_string(ret) < 0) {
SLang_verror(SL_RunTime_Error,
(char *)"%s: Failed to push %s property of %s",