This is the mail archive of the
cluster-cvs@sourceware.org
mailing list for the cluster.
cluster: STABLE3 - rgmanager: Fix stack overflows on stress testing
- From: Lon Hohberger <lon at fedoraproject dot org>
- To: cluster-cvs-relay at redhat dot com
- Date: Mon, 22 Jun 2009 13:33:32 +0000 (UTC)
- Subject: cluster: STABLE3 - rgmanager: Fix stack overflows on stress testing
Gitweb: http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=8395896c77cef54c81f8123af1c93a0137465e53
Commit: 8395896c77cef54c81f8123af1c93a0137465e53
Parent: 3ad71b4ee6d277ff87d83683bb65f6d4cc69d905
Author: Lon Hohberger <lhh@redhat.com>
AuthorDate: Fri Jun 19 18:20:46 2009 -0400
Committer: Lon Hohberger <lhh@redhat.com>
CommitterDate: Mon Jun 22 09:32:04 2009 -0400
rgmanager: Fix stack overflows on stress testing
S/Lang requires you to eat all the values on the
stack if not assigned, or you can discard all values,
but you can't take 2/5 without explicitly discarding
the other three.
Signed-off-by: Lon Hohberger <lhh@redhat.com>
---
rgmanager/src/resources/default_event_script.sl | 16 ++++++++--------
1 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/rgmanager/src/resources/default_event_script.sl b/rgmanager/src/resources/default_event_script.sl
index 9144526..7809b20 100644
--- a/rgmanager/src/resources/default_event_script.sl
+++ b/rgmanager/src/resources/default_event_script.sl
@@ -36,7 +36,7 @@ define separate_nodes(node_list)
len = length(services);
for (x = 0; x < len; x++) {
- (owner, state) = service_status(services[x]);
+ (,,, owner, state) = service_status(services[x]);
if (owner < 0) {
continue;
}
@@ -99,7 +99,7 @@ define exclusive_prioritize(svc, node_list)
continue;
}
- (owner, state) = service_status(services[x]);
+ (,,, owner, state) = service_status(services[x]);
if (owner < 0) {
continue;
}
@@ -148,14 +148,14 @@ define move_or_start(service, node_list)
depends = service_property(service, "depend");
if (depends != "") {
- (owner, state) = service_status(depends);
+ (,,, owner, state) = service_status(depends);
if (owner < 0) {
debug(service, " is not runnable; dependency not met");
return ERR_DEPEND;
}
}
- (owner, state) = service_status(service);
+ (,,, owner, state) = service_status(service);
debug("Evaluating ", service, " state=", state, " owner=", owner);
len = length(node_list);
@@ -220,7 +220,7 @@ define allowed_nodes(service)
(nofailback, restricted, ordered, nodes_domain) =
service_domain_info(service);
- (owner, state) = service_status(service);
+ (,,, owner, state) = service_status(service);
anodes = nodes_online();
@@ -270,7 +270,7 @@ define allowed_nodes(service)
(nofailback, restricted, ordered, nodes_domain) =
service_domain_info(service);
- (owner, state) = service_status(service);
+ (,,, owner, state) = service_status(service);
anodes = nodes_online();
@@ -481,7 +481,7 @@ define default_service_event_handler()
continue;
}
- (owner, state) = service_status(services[x]);
+ (,,, owner, state) = service_status(services[x]);
if ((service_state == "started") and (owner < 0) and
(state == "stopped")) {
info("Dependency met; starting ", services[x]);
@@ -514,7 +514,7 @@ define default_user_event_handler()
variable owner, state;
nodes = allowed_nodes(service_name);
- (owner, state) = service_status(service_name);
+ (,,, owner, state) = service_status(service_name);
if (user_request == USER_RESTART) {