This is the mail archive of the
cluster-cvs@sourceware.org
mailing list for the cluster.
cluster: RHEL5 - rgmanager: Fix segfault from missing initializers
- From: Lon Hohberger <lon at fedoraproject dot org>
- To: cluster-cvs-relay at redhat dot com
- Date: Wed, 8 Apr 2009 20:51:39 +0000 (UTC)
- Subject: cluster: RHEL5 - rgmanager: Fix segfault from missing initializers
Gitweb: http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=d5dba53a3bc5c20629b449bee5e3b0be4c71b538
Commit: d5dba53a3bc5c20629b449bee5e3b0be4c71b538
Parent: edab820147b90a2190f3d7487f28a35040f667a0
Author: Lon Hohberger <lhh@redhat.com>
AuthorDate: Wed Apr 8 16:49:04 2009 -0400
Committer: Lon Hohberger <lhh@redhat.com>
CommitterDate: Wed Apr 8 16:50:40 2009 -0400
rgmanager: Fix segfault from missing initializers
If the sets are empty or malloc fails, there is
a chance that the set lengths will not be zero
like they should, causing a segfault.
Signed-off-by: Lon Hohberger <lhh@redhat.com>
---
rgmanager/src/daemons/groups.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/rgmanager/src/daemons/groups.c b/rgmanager/src/daemons/groups.c
index 6d2ce38..94fa303 100644
--- a/rgmanager/src/daemons/groups.c
+++ b/rgmanager/src/daemons/groups.c
@@ -430,9 +430,9 @@ check_depend_safe(char *rg_name)
int
check_rdomain_crash(char *svcName)
{
- int *nodes = NULL, nodecount;
- int *fd_nodes = NULL, fd_nodecount, fl;
- int *isect = NULL, icount;
+ int *nodes = NULL, nodecount = 0;
+ int *fd_nodes = NULL, fd_nodecount = 0, fl = 0;
+ int *isect = NULL, icount = 0;
char fd_name[256];
if (_group_property(svcName, "domain", fd_name, sizeof(fd_name)) != 0)