This is the mail archive of the cluster-cvs@sourceware.org mailing list for the cluster.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

cluster: STABLE2 - fenced: fix premature free of victim name


Gitweb:        http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=aee97b180e80c9f8b90b8fca63004afe3b289962
Commit:        aee97b180e80c9f8b90b8fca63004afe3b289962
Parent:        05985c63592e45d3df24186e59768a5eccf485d6
Author:        David Teigland <teigland@redhat.com>
AuthorDate:    Tue Mar 31 11:02:03 2009 -0500
Committer:     David Teigland <teigland@redhat.com>
CommitterDate: Tue Mar 31 11:02:03 2009 -0500

fenced: fix premature free of victim name

also fixes fencing for multiple methods

(from STABLE3)

Signed-off-by: David Teigland <teigland@redhat.com>
---
 fence/fenced/agent.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/fence/fenced/agent.c b/fence/fenced/agent.c
index a41dd03..dd3ef2b 100644
--- a/fence/fenced/agent.c
+++ b/fence/fenced/agent.c
@@ -354,8 +354,6 @@ int dispatch_fence_agent(char *victim, int force)
 
 		if (device)
 			free(device);
-		if (victim_nodename)
-			free(victim_nodename);
 		free(method);
 
 		if (!error) {
@@ -364,6 +362,9 @@ int dispatch_fence_agent(char *victim, int force)
 		}
 	}
 
+	if (victim_nodename)
+		free(victim_nodename);
+
 	ccs_disconnect(cd);
 
 	return error;


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]