This is the mail archive of the
cluster-cvs@sourceware.org
mailing list for the cluster.
cluster: STABLE3 - cman: Fix crash caused by cman_tool version -r0
- From: Christine Caulfield <chrissie at fedoraproject dot org>
- To: cluster-cvs-relay at redhat dot com
- Date: Fri, 20 Mar 2009 08:23:51 +0000 (UTC)
- Subject: cluster: STABLE3 - cman: Fix crash caused by cman_tool version -r0
Gitweb: http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=10dd5397419c8eeab1ebe77342fae5fb4fe4c0fd
Commit: 10dd5397419c8eeab1ebe77342fae5fb4fe4c0fd
Parent: 106fd64f029b9586c488aa76d1d32ed125682d8d
Author: Christine Caulfield <ccaulfie@redhat.com>
AuthorDate: Fri Mar 20 08:22:58 2009 +0000
Committer: Christine Caulfield <ccaulfie@redhat.com>
CommitterDate: Fri Mar 20 08:22:58 2009 +0000
cman: Fix crash caused by cman_tool version -r0
A reload could (probably would!) crash
corosync if the command cman_tool version -r0 was issued. This was due
to accessing an uninitialised handle.
Signed-off-by: Christine Caulfield <ccaulfie@redhat.com>
---
cman/daemon/cman-preconfig.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/cman/daemon/cman-preconfig.c b/cman/daemon/cman-preconfig.c
index 05f9cb4..93e940a 100644
--- a/cman/daemon/cman-preconfig.c
+++ b/cman/daemon/cman-preconfig.c
@@ -966,7 +966,7 @@ static int copy_config_tree(struct objdb_iface_ver0 *objdb, hdb_handle_t source_
objdb->object_name_get(source_object, object_name, &object_name_len);
objdb->object_find_create(target_parent_object, object_name, strlen(object_name), &find_handle);
- if (always_create || objdb->object_find_next(find_handle, &object_handle))
+ if (always_create || objdb->object_find_next(find_handle, &new_object))
objdb->object_create(target_parent_object, &new_object, object_name, object_name_len);
objdb->object_find_destroy(find_handle);