This is the mail archive of the
cluster-cvs@sourceware.org
mailing list for the cluster.
cluster: STABLE3 - rgmanager: Remove sleep in startup of event thread
- From: Lon Hohberger <lon at fedoraproject dot org>
- To: cluster-cvs-relay at redhat dot com
- Date: Fri, 6 Mar 2009 15:14:38 +0000 (UTC)
- Subject: cluster: STABLE3 - rgmanager: Remove sleep in startup of event thread
Gitweb: http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=b4939e9e1ded08594c3b86237b24318f3d23414f
Commit: b4939e9e1ded08594c3b86237b24318f3d23414f
Parent: f1d8657897d4c70f75fbc15a2b7ca34b0f7a27ca
Author: Lon Hohberger <lhh@redhat.com>
AuthorDate: Thu Mar 5 16:23:33 2009 -0500
Committer: Lon Hohberger <lhh@redhat.com>
CommitterDate: Fri Mar 6 10:13:47 2009 -0500
rgmanager: Remove sleep in startup of event thread
There's no reason to sleep here, and it delays processing
of potentially important events.
Signed-off-by: Lon Hohberger <lhh@redhat.com>
---
rgmanager/src/daemons/rg_event.c | 13 +++----------
1 files changed, 3 insertions(+), 10 deletions(-)
diff --git a/rgmanager/src/daemons/rg_event.c b/rgmanager/src/daemons/rg_event.c
index 7321e25..1c1f195 100644
--- a/rgmanager/src/daemons/rg_event.c
+++ b/rgmanager/src/daemons/rg_event.c
@@ -46,8 +46,8 @@ event_table_t *master_event_table = NULL;
void
set_transition_throttling(int nsecs)
{
- if (nsecs < 0)
- nsecs = 0;
+ if (nsecs < 1)
+ nsecs = 1;
transition_throttling = nsecs;
}
@@ -358,19 +358,12 @@ _event_thread_f(void __attribute__ ((unused)) *arg)
struct timespec expire;
int count = 0;
- /* Event thread usually doesn't hang around. When it's
- spawned, sleep for this many seconds in order to let
- some events queue up */
- if (transition_throttling && !central_events) {
- sleep(transition_throttling);
- }
-
while (1) {
pthread_mutex_lock(&event_queue_mutex);
ev = event_queue;
if (!ev && !central_events) {
gettimeofday(&now, NULL);
- expire.tv_sec = now.tv_sec + 5;
+ expire.tv_sec = now.tv_sec + transition_throttling;
expire.tv_nsec = now.tv_usec * 1000;
pthread_cond_timedwait(&event_queue_cond,
&event_queue_mutex,