This is the mail archive of the
cluster-cvs@sourceware.org
mailing list for the cluster.
master - libfence: no logging
- From: David Teigland <teigland at fedoraproject dot org>
- To: cluster-cvs-relay at redhat dot com
- Date: Mon, 10 Nov 2008 20:22:20 +0000 (UTC)
- Subject: master - libfence: no logging
Gitweb: http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=fd5da887221b50e6ef79921813f515d184505d6b
Commit: fd5da887221b50e6ef79921813f515d184505d6b
Parent: 1a72ddf4738bf8511daae6ee429414b4e65c7bdf
Author: David Teigland <teigland@redhat.com>
AuthorDate: Mon Nov 10 14:04:45 2008 -0600
Committer: David Teigland <teigland@redhat.com>
CommitterDate: Mon Nov 10 14:04:45 2008 -0600
libfence: no logging
Libraries shouldn't do logging, and the two calls to syslog here
are not essential.
Signed-off-by: David Teigland <teigland@redhat.com>
---
fence/libfence/agent.c | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/fence/libfence/agent.c b/fence/libfence/agent.c
index 247c6d5..1b118e9 100644
--- a/fence/libfence/agent.c
+++ b/fence/libfence/agent.c
@@ -7,7 +7,6 @@
#include <string.h>
#include <errno.h>
#include <time.h>
-#include <syslog.h>
#include "ccs.h"
@@ -36,7 +35,9 @@ static void display_agent_output(const char *agent, int fd)
break;
} else if (ret > 0) {
buf[ret] = '\0';
+ /*
syslog(LOG_ERR, "agent \"%s\" reports: %s", agent, buf);
+ */
}
} while (ret > 0);
}
@@ -285,10 +286,8 @@ int fence_node(char *victim)
int num_methods, num_devices, m, d, error = -1, cd;
cd = ccs_force_connect(NULL, 0);
- if (cd < 0) {
- syslog(LOG_ERR, "cannot connect to ccs %d\n", cd);
+ if (cd < 0)
return -1;
- }
if (ccs_lookup_nodename(cd, victim, &victim_nodename) == 0)
victim = victim_nodename;